Conversation
cmaddox5
reviewed
Jun 12, 2025
| gtfs_archive_storage_request_fn: {Arrow.Mock.ExAws.Request, :request}, | ||
| hastus_export_storage_enabled?: false, | ||
| hastus_export_storage_request_fn: {Arrow.Mock.ExAws.Request, :request} | ||
| alias Arrow.Mock.ExAws.Request |
Contributor
There was a problem hiding this comment.
My biggest complaint with this is how it chooses to pull things into an alias. It seems annoyingly inconsistent. Looking at line 56 below, why wasn't that also made one?
cmaddox5
reviewed
Jun 12, 2025
| group_by: r.disruption_id | ||
| ) | ||
| |> Repo.one!() | ||
| Repo.one!(from(r in DisruptionRevision, where: r.disruption_id == ^id, select: max(r.id), group_by: r.disruption_id)) |
Contributor
There was a problem hiding this comment.
This is a tricky refactor too. I get why it made the change, but I feel like it's a little less readable now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: TICKET_NAME
[Please include a brief description of what was changed]
Reviewer Checklist